Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/perf/page_sets/big_js.py

Issue 1060563005: Extend the BigJs benchmark: add a YouTube page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/big_js.json » ('j') | tools/perf/page_sets/data/big_js.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/big_js.py
diff --git a/tools/perf/page_sets/big_js.py b/tools/perf/page_sets/big_js.py
index 48295be718ae4270352bd54541d1e277f9560eb7..70cce251241875f5a91459feabdb5e90dcb19991 100644
--- a/tools/perf/page_sets/big_js.py
+++ b/tools/perf/page_sets/big_js.py
@@ -14,12 +14,15 @@ class BigJsPageSet(page_set_module.PageSet):
bucket=page_set_module.PARTNER_BUCKET,
user_agent_type='desktop')
- # Page sets with only one page don't work well, since we end up reusing a
+ # www.foo.com is a dummy page to make it easier to run only one interesting
+ # page at a time. You can't just run the interesting page on its own: Page
+ # sets with only one page don't work well, since we end up reusing a
# renderer all the time and it keeps its memory caches alive (see
- # crbug.com/403735). Add a dummy second page here.
+ # crbug.com/403735).
Sami 2015/04/07 11:07:53 Hmm, interesting, I didn't know about this! Do you
marja 2015/04/07 11:59:58 It's generally probably not a problem since most o
Sami 2015/04/07 12:59:05 Gotcha, thanks.
urls_list = [
- 'http://beta.unity3d.com/jonas/DT2/',
- 'http://www.foo.com',
+ 'http://beta.unity3d.com/jonas/DT2/',
+ 'https://www.youtube.com/watch?v=IJNR2EpS0jw',
+ 'http://www.foo.com',
]
for url in urls_list:
self.AddUserStory(page_module.Page(url, self))
« no previous file with comments | « no previous file | tools/perf/page_sets/data/big_js.json » ('j') | tools/perf/page_sets/data/big_js.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698