Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060553003: Web MIDI: call AccumulateMidiBytesSent() after operation finished (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima
Modified:
5 years, 8 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: call AccumulateMidiBytesSent() after operation finished For better flow control, call AccumulateMidiBytesSent() after send operation finished. BUG=467442 Committed: https://crrev.com/f3be14c499ef4eb95f482955ee6b2d57e6fa8755 Cr-Commit-Position: refs/heads/master@{#324037}

Patch Set 1 #

Patch Set 2 : test fix: use existing client #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M media/midi/midi_manager.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M media/midi/midi_manager.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 4 chunks +6 lines, -10 lines 0 comments Download
M media/midi/midi_scheduler.h View 2 chunks +7 lines, -2 lines 0 comments Download
M media/midi/midi_scheduler.cc View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Takashi Toyoshima
PTAL
5 years, 8 months ago (2015-04-06 14:30:19 UTC) #2
Takashi Toyoshima
FYI, I checked local Android Chrome build working fine with http://d.hatena.ne.jp/yoya/20150111/pokemiku
5 years, 8 months ago (2015-04-06 14:32:08 UTC) #3
yhirano
lgtm https://codereview.chromium.org/1060553003/diff/20001/media/midi/midi_manager.h File media/midi/midi_manager.h (right): https://codereview.chromium.org/1060553003/diff/20001/media/midi/midi_manager.h#newcode90 media/midi/midi_manager.h:90: // already close, do nothing. closed?
5 years, 8 months ago (2015-04-07 12:06:33 UTC) #4
Takashi Toyoshima
https://codereview.chromium.org/1060553003/diff/20001/media/midi/midi_manager.h File media/midi/midi_manager.h (right): https://codereview.chromium.org/1060553003/diff/20001/media/midi/midi_manager.h#newcode90 media/midi/midi_manager.h:90: // already close, do nothing. On 2015/04/07 12:06:33, yhirano ...
5 years, 8 months ago (2015-04-07 12:50:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060553003/40001
5 years, 8 months ago (2015-04-07 12:51:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-07 14:03:00 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 14:03:52 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f3be14c499ef4eb95f482955ee6b2d57e6fa8755
Cr-Commit-Position: refs/heads/master@{#324037}

Powered by Google App Engine
This is Rietveld 408576698