Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1060533003: Experiment: reduce heap growing factor to investigate OOM impact. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev, Benedikt Meurer, mvstanton
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Experiment: reduce heap growing factor to investigate OOM impact. This CL will be reverted after getting sufficient data. BUG= Committed: https://crrev.com/8b737395c8fcde35cbfbed6607f767ed48eefc5b Cr-Commit-Position: refs/heads/master@{#27804}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/heap/heap.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 27 (13 generated)
Hannes Payer (out of office)
5 years, 8 months ago (2015-04-10 10:21:53 UTC) #2
ulan
lgtm
5 years, 8 months ago (2015-04-10 10:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060533003/1
5 years, 8 months ago (2015-04-13 08:55:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3744)
5 years, 8 months ago (2015-04-13 09:19:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060533003/1
5 years, 8 months ago (2015-04-13 11:42:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3755)
5 years, 8 months ago (2015-04-13 12:13:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060533003/20001
5 years, 8 months ago (2015-04-13 14:52:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3768)
5 years, 8 months ago (2015-04-13 15:24:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060533003/40001
5 years, 8 months ago (2015-04-14 05:27:41 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4826)
5 years, 8 months ago (2015-04-14 05:46:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060533003/60001
5 years, 8 months ago (2015-04-14 06:24:41 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-14 06:58:43 UTC) #25
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/8b737395c8fcde35cbfbed6607f767ed48eefc5b Cr-Commit-Position: refs/heads/master@{#27804}
5 years, 8 months ago (2015-04-14 06:59:00 UTC) #26
Hannes Payer (out of office)
5 years, 8 months ago (2015-04-16 09:06:27 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1085353003/ by hpayer@chromium.org.

The reason for reverting is: Experiment done..

Powered by Google App Engine
This is Rietveld 408576698