chrome/browser/password_manager/password_form_manager.cc - Issue 106053008: [Mac] Passwords: Don't always prompt to access passwords saved by other browsers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 106053008: [Mac] Passwords: Don't always prompt to access passwords saved by other browsers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix yet another compile failure. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_form_manager.h ('k') | chrome/browser/password_manager/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_form_manager.cc

diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc

index f129ae7cdad50d70ef8243ecf4423695e89d961d..5b5adb7232af677889ed37eb70bfaebee1dfe1d6 100644

--- a/chrome/browser/password_manager/password_form_manager.cc

+++ b/chrome/browser/password_manager/password_form_manager.cc

@@ -254,7 +254,8 @@ void PasswordFormManager::Save() {

UpdateLogin();

}

-void PasswordFormManager::FetchMatchingLoginsFromPasswordStore() {

+void PasswordFormManager::FetchMatchingLoginsFromPasswordStore(

+ PasswordStore::AuthorizationPromptPolicy prompt_policy) {

DCHECK_EQ(state_, PRE_MATCHING_PHASE);

state_ = MATCHING_PHASE;

PasswordStore* password_store = PasswordStoreFactory::GetForProfile(

@@ -263,7 +264,7 @@ void PasswordFormManager::FetchMatchingLoginsFromPasswordStore() {

NOTREACHED();

return;

}

- password_store->GetLogins(observed_form_, this);

+ password_store->GetLogins(observed_form_, prompt_policy, this);

}

bool PasswordFormManager::HasCompletedMatching() {