Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 106053007: Add beginEvent/endEvent listeners via the onbegin/onend attributes. (Closed)

Created:
7 years ago by Erik Dahlström (inactive)
Modified:
7 years ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add onrepeat too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
A + LayoutTests/svg/animations/onbegin.svg View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/svg/animations/onbegin-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/animations/onend.svg View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/svg/animations/onend-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/animations/onrepeat.svg View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/svg/animations/onrepeat-expected.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Dahlström (inactive)
7 years ago (2013-12-06 16:34:04 UTC) #1
pdr.
On 2013/12/06 16:34:04, Erik Dahlström wrote: LGTM Do you mind adding a link to the ...
7 years ago (2013-12-06 21:16:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/106053007/20001
7 years ago (2013-12-09 09:13:36 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 10:19:20 UTC) #4
Message was sent while issue was closed.
Change committed as 163419

Powered by Google App Engine
This is Rietveld 408576698