Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060483003: Add ImageLoader support for sizes based Client-Hints RW values (Closed)

Created:
5 years, 8 months ago by Yoav Weiss
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add ImageLoader support for sizes based Client-Hints RW values This CL adds support for RW hints that are based on the element's sizes attribute to ImageLoader, to cover dynamically added images. BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193521

Patch Set 1 #

Patch Set 2 : Fix test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
A + LayoutTests/http/tests/misc/client-hints-dynamic-rw-sizes.html View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 3 chunks +10 lines, -12 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yoav Weiss
5 years, 8 months ago (2015-04-09 21:28:13 UTC) #2
Yoav Weiss
On 2015/04/09 21:28:13, Yoav Weiss wrote: Hmm, some test failures that seem related. Looking into ...
5 years, 8 months ago (2015-04-10 05:32:57 UTC) #3
Yoav Weiss
On 2015/04/10 05:32:57, Yoav Weiss wrote: > On 2015/04/09 21:28:13, Yoav Weiss wrote: > > ...
5 years, 8 months ago (2015-04-10 06:08:10 UTC) #4
Mike West
LGTM.
5 years, 8 months ago (2015-04-10 06:28:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060483003/20001
5 years, 8 months ago (2015-04-10 07:30:34 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 07:52:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193521

Powered by Google App Engine
This is Rietveld 408576698