Make one-bit bit fields unsigned.

Make one-bit bit fields unsigned.

VC++ 2015 gives the following warning when compiling jsoncpp:

  json_value.cpp(480): warning C4463: overflow; assigning 1 to bit-field
  that can only hold values from -1 to 0

This warning is correct. A signed one-bit value can only hold 0 and -1.
This is true on gcc and clang, but only VC++ 2015 warns about it.

The code works because the stored value is never compared against 1 or
printed, but the current code is likely to cause surprises or bugs in the
future and should be fixed.

R=cpu@chromium.org
BUG=440500
Committed: https://crrev.com/707c3acd012287f3b4897bedaf57c60fbd4044bd
Cr-Commit-Position: refs/heads/master@{#325330}

[brucedawson, 2015-04-07 18:21:34]

brucedawson@chromium.org changed reviewers:
+ mallinath@chromium.org

[brucedawson, 2015-04-07 18:38:10]

brucedawson@chromium.org changed reviewers:
+ ronghuawu@chromium.org
- mallinath@chromium.org

[brucedawson, 2015-04-07 18:38:10]

Changing reviewer since mallinath is tagged as (Gone from Chromium). Consider
removing them from jsoncpp\OWNERS so they aren't recommended as reviewer by
presubmit checks?

[Mallinath (Gone from Chromium), 2015-04-07 19:49:41]

On 2015/04/07 18:38:10, brucedawson wrote:
> Changing reviewer since mallinath is tagged as (Gone from Chromium). Consider
> removing them from jsoncpp\OWNERS so they aren't recommended as reviewer by
> presubmit checks?

Sorry for about that, I will from owners file.

[Ronghua Wu (Left Chromium), 2015-04-07 20:14:38]

Sorry, I left chrome as well. Can you find someone else from the owner file?

[brucedawson, 2015-04-07 20:27:44]

brucedawson@chromium.org changed reviewers:
+ cpu@chromium.org
- ronghuawu@chromium.org

[brucedawson, 2015-04-07 20:28:11]

Third try at a review. Both people in the
third_party\jsoncpp\OWNERS file have left Chromium. Can
you take over? Should I update or remove the OWNERS file as part of this change?

[scottmg, 2015-04-13 22:45:50]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-04-13 22:45:51]

https://codereview.chromium.org/1060383002/diff/1/third_party/jsoncpp/overrid...
File third_party/jsoncpp/overrides/include/json/value.h (right):

https://codereview.chromium.org/1060383002/diff/1/third_party/jsoncpp/overrid...
third_party/jsoncpp/overrides/include/json/value.h:501: unsigned allocated_ : 1;
can you make these `unsigned int` to match the other one?

[brucedawson, 2015-04-14 23:40:46]

Patch file added, and changed from 'unsigned' to 'unsigned int' for consistency
(suggested by Scott)

[brucedawson, 2015-04-14 23:51:20]

brucedawson@chromium.org changed reviewers:
+ sbc@chromium.org
- cpu@chromium.org, scottmg@chromium.org

[brucedawson, 2015-04-14 23:52:34]

We're working on getting Chrome to build with VS 2015 (release candidate).

[Sam Clegg, 2015-04-15 00:01:36]

Can you update the README.chromium?

If your going to add a patch it shouldn't it contain the existing change to
value.h? (looks like just and include path change)

I'm also working on removing this code from the renderer completely and rolling
jsoncpp.  I will make sure this change gets upstreamed too if it hasn't already
be fixed there.

[brucedawson, 2015-04-15 00:18:59]

I updated the patch file and README.chromium.

Upstreaming this would be great.

Signed bit fields are awesome!

[brucedawson, 2015-04-15 18:19:12]

PTAL?

[Sam Clegg, 2015-04-15 18:31:46]

lgtm

[brucedawson, 2015-04-15 20:49:44]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-04-15 20:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060383002/60001

[commit-bot: I haz the power, 2015-04-15 22:43:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-15 22:44:00]

Patchset 4 (id:??) landed as
https://crrev.com/707c3acd012287f3b4897bedaf57c60fbd4044bd
Cr-Commit-Position: refs/heads/master@{#325330}

[lilianareyes171755, 2015-05-18 08:18:09]

lilianareyes171755@gmail.com changed reviewers:
+ lilianareyes171755@gmail.com