Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1060373006: [turbofan] Get rid of SourcePositionInstruction. (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Get rid of SourcePositionInstruction. R=bmeurer@chromium.org Committed: https://crrev.com/2299f57fd3b7f2eb2dcd5dc048574613385a0605 Cr-Commit-Position: refs/heads/master@{#27808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -125 lines) Patch
M src/compiler/code-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +53 lines, -56 lines 0 comments Download
M src/compiler/instruction.h View 4 chunks +6 lines, -38 lines 0 comments Download
M src/compiler/instruction.cc View 3 chunks +26 lines, -15 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/jump-threading.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/move-optimizer.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
On 2015/04/14 07:45:03, dcarney wrote: > mailto:dcarney@chromium.org changed reviewers: > + mailto:bmeurer@chromium.org ptal, probably not ...
5 years, 8 months ago (2015-04-14 07:45:57 UTC) #2
Benedikt Meurer
Way better, thanks. LGTM
5 years, 8 months ago (2015-04-14 07:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060373006/1
5 years, 8 months ago (2015-04-14 07:49:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 08:08:35 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 08:08:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2299f57fd3b7f2eb2dcd5dc048574613385a0605
Cr-Commit-Position: refs/heads/master@{#27808}

Powered by Google App Engine
This is Rietveld 408576698