Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 1060353002: Fix 'gsutil' self-discovery. (Closed)

Created:
5 years, 8 months ago by dnj
Modified:
5 years, 8 months ago
Reviewers:
vapier, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Fix 'gsutil' self-discovery. Use 'realpath' instead of 'abspath' for self-discovery. This fixes an issue where 'gsutil' cannot find its dependencies when it is referenced through a symbolic link. Specifically, the symlink was: /b/scripts => /b/build/scripts 'gsutil' was called as: /b/scripts/slave/../../../depot_tools/third_party/gsutil/gsutil Because '/b/scripts/slave' resolves to '/b/build/scripts/slave', the three parent directory operators actually resolve to '/b', but 'os.path.abspath' blindly resolves them to '/'. BUG=chromium:474442 TEST=live - Signed onto failing bot, made this change, 'gsutil' works. R=hinoka@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/gsutil/gsutil View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dnj
+vapier@ FYI. PTAL! BTW: This 'gsutil' self-fixing seems like logic that would be better located ...
5 years, 8 months ago (2015-04-07 15:51:55 UTC) #2
hinoka
lgtm Though I still prefer calling scripts use "depot_tools/gsutil.py --force-version 4.7" instead of this version, ...
5 years, 8 months ago (2015-04-08 01:24:47 UTC) #3
vapier
this is really old branched code that was last updated 2.5 years ago. CrOS has ...
5 years, 8 months ago (2015-04-08 01:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060353002/1
5 years, 8 months ago (2015-04-08 01:52:18 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 01:54:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294712

Powered by Google App Engine
This is Rietveld 408576698