Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1060263003: Revert of VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
Reviewers:
dcarney, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (patchset #3 id:40001 of https://codereview.chromium.org/1067573003/) Reason for revert: [Sheriff] Speculative revert for windows failure... will reland if it doesn't help: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%202/builds/2891 Original issue's description: > VectorICs: megamorphic keyed loads in crankshaft don't need a vector. > > They are content with a dummy vector, as MISSES won't result in > changing the real vector/slot at all. > > BUG= > > Committed: https://crrev.com/c8e4d57d3b3036a05902f5b916cb5d853a57393c > Cr-Commit-Position: refs/heads/master@{#27788} TBR=dcarney@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/dc65e62abde16c36c9f5ebb878c92674e651a58e Cr-Commit-Position: refs/heads/master@{#27790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +21 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of VectorICs: megamorphic keyed loads in crankshaft don't need a vector.
5 years, 8 months ago (2015-04-13 16:18:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060263003/1
5 years, 8 months ago (2015-04-13 16:19:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 16:19:35 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 16:19:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc65e62abde16c36c9f5ebb878c92674e651a58e
Cr-Commit-Position: refs/heads/master@{#27790}

Powered by Google App Engine
This is Rietveld 408576698