Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1060243002: Use "share_screenshot_as_stream" instead of Intent.EXTRA_STREAM (Closed)

Created:
5 years, 8 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "share_screenshot_as_stream" instead of Intent.EXTRA_STREAM When both a URL as Intent.EXTRA_TEXT and a screenshot as Intent.EXTRA_STREAM present, most apps favor the latter. So we need to use a new extra name for a screenshot so that a URL could be prioritized as it is. BUG=455996 Committed: https://crrev.com/25e43a11186a1500420f772da4e08e2e926a9454 Cr-Commit-Position: refs/heads/master@{#324121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
Please review this CL.
5 years, 8 months ago (2015-04-07 06:17:32 UTC) #2
Ted C
lgtm
5 years, 8 months ago (2015-04-07 17:33:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060243002/1
5 years, 8 months ago (2015-04-07 20:43:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 21:15:27 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:16:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25e43a11186a1500420f772da4e08e2e926a9454
Cr-Commit-Position: refs/heads/master@{#324121}

Powered by Google App Engine
This is Rietveld 408576698