Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Issue 1060233002: Remove ICS support from SurfaceTexture (Closed)

Created:
5 years, 8 months ago by boliu
Modified:
5 years, 8 months ago
Reviewers:
no sievers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ICS support from SurfaceTexture We don't support API level 14 and 15 anymore. \o/ Also remove CreateSingleBuffered which is dead code not being used. BUG=473837 Committed: https://crrev.com/150cd1f8e106899fd7a2e70570fa8d208f1f4de8 Cr-Commit-Position: refs/heads/master@{#324145}

Patch Set 1 #

Patch Set 2 : remove CreateSingleBuffered #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -76 lines) Patch
M ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformWrapper.java View 1 3 chunks +0 lines, -20 lines 0 comments Download
M ui/gl/android/surface_texture.h View 1 3 chunks +0 lines, -13 lines 0 comments Download
M ui/gl/android/surface_texture.cc View 1 6 chunks +9 lines, -43 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
boliu
ptal btw, I didn't find anything calling createSingleBuffered, can that be removed too?
5 years, 8 months ago (2015-04-07 01:25:07 UTC) #2
no sievers
lgtm. feel free to remove the unused method too if you want.
5 years, 8 months ago (2015-04-07 21:44:47 UTC) #3
boliu
Removed CreateSingleBuffered, take another look?
5 years, 8 months ago (2015-04-07 22:07:25 UTC) #4
no sievers
lgtm
5 years, 8 months ago (2015-04-07 22:08:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060233002/20001
5 years, 8 months ago (2015-04-07 22:13:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 22:56:38 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:58:24 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/150cd1f8e106899fd7a2e70570fa8d208f1f4de8
Cr-Commit-Position: refs/heads/master@{#324145}

Powered by Google App Engine
This is Rietveld 408576698