Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1060223002: Remove parsing for display:block/inline-block. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove parsing for display:block/inline-block. The default is now column flexboxes, which are almost the same as blocks. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e618ecd320985c87c5771c903abe530ab1b81879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
What happens when you put inlines inside a flexbox? otherwise lgtm.
5 years, 8 months ago (2015-04-07 00:22:12 UTC) #2
eseidel
i.e. how do you get multi-line text now?
5 years, 8 months ago (2015-04-07 00:22:26 UTC) #3
ojan
On 2015/04/07 at 00:22:12, eseidel wrote: > What happens when you put inlines inside a ...
5 years, 8 months ago (2015-04-07 02:19:28 UTC) #4
ojan
5 years, 8 months ago (2015-04-07 02:19:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e618ecd320985c87c5771c903abe530ab1b81879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698