Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1060193005: Add support for externally provided refresh tokens. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Add support for externally provided refresh tokens. OAuth token cache file (as implemented by oauth2client library) stores refresh token and can in theory be deployed via Puppet as the credential. But it is mutated by the library (to store access tokens, rotated each hour), and so it is not static and managing it via Puppet (or however else) is a big pain. Instead, now depot_tools accepts --auth-refresh-token-json parameter with a path to a static JSON file (with minimal body being {"refresh_token": "....."}). It can be used to pass previously prepared refresh tokens of role accounts. It will be used for blink DEPS roller account and similar @chromium.org accounts. R=maruel@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294870

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -21 lines) Patch
M auth.py View 1 16 chunks +108 lines, -21 lines 0 comments Download
M tests/git_cl_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vadim Sh.
tl;dr we have "role accounts" (commit-bot@chromium.org, blink deps roller, etc.) that are like service accounts ...
5 years, 8 months ago (2015-04-17 01:44:05 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/1060193005/diff/1/auth.py File auth.py (right): https://codereview.chromium.org/1060193005/diff/1/auth.py#newcode274 auth.py:274: logging.warning('Failed to revoke refresh token: %s', e) you ...
5 years, 8 months ago (2015-04-17 01:49:50 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1060193005/diff/1/auth.py File auth.py (right): https://codereview.chromium.org/1060193005/diff/1/auth.py#newcode274 auth.py:274: logging.warning('Failed to revoke refresh token: %s', e) On 2015/04/17 ...
5 years, 8 months ago (2015-04-17 02:38:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060193005/20001
5 years, 8 months ago (2015-04-17 02:38:58 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 02:42:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294870

Powered by Google App Engine
This is Rietveld 408576698