Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: mojo/public/dart/src/application.dart

Issue 1060193002: Provide mechanism to close immediately to Dart bindings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/test/validation_test.dart ('k') | mojo/public/dart/src/application_connection.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/src/application.dart
diff --git a/mojo/public/dart/src/application.dart b/mojo/public/dart/src/application.dart
index 03d0843f4e55e1d7947ce27064746eea71eb7f75..f6ee4735bf21fe81e16121e1016ccc958c7daf8a 100644
--- a/mojo/public/dart/src/application.dart
+++ b/mojo/public/dart/src/application.dart
@@ -41,9 +41,11 @@ class _ApplicationImpl implements application_mojom.Application {
@override
void requestQuit() => _application._requestQuitAndClose();
- Future close({bool nodefer: false}) {
- if (shell != null) shell.close();
- return _stub.close();
+ Future close({bool immediate: false}) {
+ if (shell != null) {
+ shell.close(immediate: immediate);
+ }
+ return _stub.close(immediate: immediate);
}
}
@@ -104,11 +106,11 @@ abstract class Application {
});
}
- Future close() {
+ Future close({bool immediate: false}) {
assert(_applicationImpl != null);
- _applicationConnections.forEach((c) => c.close());
+ _applicationConnections.forEach((c) => c.close(immediate: immediate));
_applicationConnections.clear();
- return _applicationImpl.close();
+ return _applicationImpl.close(immediate: immediate);
}
// This method closes all the application connections. Used during apptesting.
« no previous file with comments | « mojo/dart/test/validation_test.dart ('k') | mojo/public/dart/src/application_connection.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698