Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1060193002: Provide mechanism to close immediately to Dart bindings (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

- Rename "nodefer" to "immediate" (gets rid of double negative in "nodefer: false"). - Immediate close means that anything pending will be discarded. - Plumb immediate all the way down to the handle watcher close call. - When an EventStream is closed because no one is listening for events, close immediately. - Don't call Dart_NewSendPort with ILLEGAL_PORT in sky embedder. - Bump DEPS to include fixes for Dart_NewSendPort and profiler signal handler executing after shared object is unloaded. - Fixes https://github.com/domokit/mojo/issues/79 R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/5d2f53716182a5fe260342ab04f4808c409a289f

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/validation_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/dart/src/application.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M mojo/public/dart/src/application_connection.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/dart/src/event_stream.dart View 1 2 3 4 5 5 chunks +11 lines, -10 lines 0 comments Download
M mojo/public/dart/src/proxy.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/dart/src/stub.dart View 1 2 4 chunks +14 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/mojo_natives.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 8 months ago (2015-04-07 19:30:44 UTC) #2
zra
lgtm with questions https://codereview.chromium.org/1060193002/diff/80001/mojo/public/dart/src/event_stream.dart File mojo/public/dart/src/event_stream.dart (right): https://codereview.chromium.org/1060193002/diff/80001/mojo/public/dart/src/event_stream.dart#newcode107 mojo/public/dart/src/event_stream.dart:107: void _localClose({bool immediate: false}) { Is ...
5 years, 8 months ago (2015-04-07 19:49:46 UTC) #3
Cutch
https://codereview.chromium.org/1060193002/diff/80001/mojo/public/dart/src/event_stream.dart File mojo/public/dart/src/event_stream.dart (right): https://codereview.chromium.org/1060193002/diff/80001/mojo/public/dart/src/event_stream.dart#newcode107 mojo/public/dart/src/event_stream.dart:107: void _localClose({bool immediate: false}) { On 2015/04/07 19:49:46, zra ...
5 years, 8 months ago (2015-04-07 19:52:13 UTC) #4
Cutch
5 years, 8 months ago (2015-04-07 19:53:10 UTC) #5
Cutch
5 years, 8 months ago (2015-04-07 20:00:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
5d2f53716182a5fe260342ab04f4808c409a289f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698