Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060163002: Localize the Downloads page. (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Localize the Downloads page. BUG=472677 Committed: https://crrev.com/a7dac1925272537bd471ecf9f471ba10bd9e13a3 Cr-Commit-Position: refs/heads/master@{#323973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-06 22:06:49 UTC) #2
James Hawkins
lgtm
5 years, 8 months ago (2015-04-06 22:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060163002/1
5 years, 8 months ago (2015-04-06 22:10:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 23:03:47 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 23:04:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a7dac1925272537bd471ecf9f471ba10bd9e13a3
Cr-Commit-Position: refs/heads/master@{#323973}

Powered by Google App Engine
This is Rietveld 408576698