Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1060153003: add new blit2 methods in support of antialiased hairlines guard flag SK_SUPPORT_LEGACY_BLITANTIH2V2 (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
reed2, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add new blit2 methods in support of antialiased hairlines before: 9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad after: 9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad BUG=skia: does require new baselines (bug chrome is guarded) Committed: https://skia.googlesource.com/skia/+/dd83031b98db4c6d3d0de2353bf115152a7d1464

Patch Set 1 #

Patch Set 2 : specialize non-opaque color as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -90 lines) Patch
M src/core/SkBlitter.h View 1 3 chunks +35 lines, -2 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 1 3 chunks +57 lines, -0 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 2 chunks +20 lines, -88 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reed1
5 years, 8 months ago (2015-04-14 19:43:15 UTC) #2
caryclark
lgtm
5 years, 8 months ago (2015-04-14 19:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060153003/20001
5 years, 8 months ago (2015-04-15 01:33:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/dd83031b98db4c6d3d0de2353bf115152a7d1464
5 years, 8 months ago (2015-04-15 01:40:00 UTC) #7
jcgregorio
5 years, 8 months ago (2015-04-15 13:16:53 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1085013003/ by jcgregorio@google.com.

The reason for reverting is: DEPS roll is failing, one such example:

http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...

More here:

   https://codereview.chromium.org/1091483003

This CL was the only CL in the roll when things started to fail..

Powered by Google App Engine
This is Rietveld 408576698