Blink use old style character string notation for Unicode

Blink use old style character string notation for Unicode

Change Blink old style character string notation to Unicode values
present in CharacterNames header file.

This change is in continuation of https://crrev.com/824263003

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194717

[h.joshi, 2015-04-27 06:00:55]

h.joshi@samsung.com changed reviewers:
+ dominik.rottsches@intel.com, eae@chromium.org

[h.joshi, 2015-04-27 06:01:48]

Pls Review.

[eae, 2015-04-27 19:57:25]

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
File Source/core/layout/line/BreakingContextInlineHeaders.h (right):

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
Source/core/layout/line/BreakingContextInlineHeaders.h:611: bool betweenWords =
c == newlineCharacter || (m_currWS != PRE && !m_atStart &&
m_renderTextInfo.m_lineBreakIterator.isBreakable(m_current.offset(),
nextBreakablePosition, breakAll ? LineBreakType::BreakAll :
LineBreakType::Normal));
This needs to be re-merged to include the keepAll logic.

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
Source/core/layout/line/BreakingContextInlineHeaders.h:842: checkForBreak =
!m_currentCharacterIsSpace && (c == space || c == characterTabulation || (c ==
newlineCharacter && !m_nextObject->preservesNewline()));
As a separate change we really should clean up the naming for these constants;
having three separate naming schemes ([name] [name]Character and character[Name]
is really inconsistent).

[h.joshi, 2015-04-28 13:07:15]

@Emil: Made suggested changes.
Pls review.

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
File Source/core/layout/line/BreakingContextInlineHeaders.h (right):

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
Source/core/layout/line/BreakingContextInlineHeaders.h:611: bool betweenWords =
c == newlineCharacter || (m_currWS != PRE && !m_atStart &&
m_renderTextInfo.m_lineBreakIterator.isBreakable(m_current.offset(),
nextBreakablePosition, breakAll ? LineBreakType::BreakAll :
LineBreakType::Normal));
On 2015/04/27 19:57:25, eae wrote:
> This needs to be re-merged to include the keepAll logic.

Done.

https://codereview.chromium.org/1060113003/diff/20001/Source/core/layout/line...
Source/core/layout/line/BreakingContextInlineHeaders.h:842: checkForBreak =
!m_currentCharacterIsSpace && (c == space || c == characterTabulation || (c ==
newlineCharacter && !m_nextObject->preservesNewline()));
Okey, will start working on the same and submit new patch
 as that will involve many changes.

[eae, 2015-04-29 16:13:36]

LGTM

[h.joshi, 2015-04-30 07:10:09]

Thank you Emil.

[h.joshi, 2015-04-30 07:10:13]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2015-04-30 07:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060113003/40001

[commit-bot: I haz the power, 2015-04-30 07:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 07:15:54]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/53956)

[h.joshi, 2015-04-30 07:35:26]

The CQ bit was checked by h.joshi@samsung.com

[h.joshi, 2015-04-30 07:35:27]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1060113003/#ps60001
(title: "Rebase patch")

[commit-bot: I haz the power, 2015-04-30 07:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1060113003/60001

[commit-bot: I haz the power, 2015-04-30 09:47:49]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194717