Issue 1060033003: [chrome/browser/safe_browsing] favor DCHECK_CURRENTLY_ON for better logs

Issue 1060033003: [chrome/browser/safe_browsing] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, grt+watch_chromium.org, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/safe_browsing BUG=466848 Committed: https://crrev.com/e161ffdfaf5bdc2115d92ae06879efb016c42fe0 Cr-Commit-Position: refs/heads/master@{#326734}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -95 lines)			Patch
M	chrome/browser/safe_browsing/browser_feature_extractor.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_host.cc	View		14 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_host_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_service.cc	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View		18 chunks	+21 lines, -21 lines	0 comments	Download
M	chrome/browser/safe_browsing/malware_details_cache.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/malware_details_history.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/ping_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View		10 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/ui_manager.cc	View		11 chunks	+12 lines, -12 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/23 17:34:33, Scott Hess wrote: > lgtm Thanks scott hess for lgtm.

5 years, 8 months ago (2015-04-24 02:16:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060033003/20001

5 years, 8 months ago (2015-04-24 02:17:17 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 03:22:29 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e161ffdfaf5bdc2115d92ae06879efb016c42fe0
Cr-Commit-Position: refs/heads/master@{#326734}