Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1060013005: Make changing your layout manager work. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make changing your layout manager work. If your layout manager changes, then you need to setNeedsLayout, otherwise the next frame doesn't even get scheduled. We already correctly handle going from not having layout to having one or vice versa by doing the more drastic reattaching since that requires changing your actual render class. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/335562bcfde6e44c18f0ca7311d75905b18fc603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M sky/engine/core/dom/Element.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/tests/layout/custom.sky View 1 chunk +31 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-15 04:18:49 UTC) #2
ojan
5 years, 8 months ago (2015-04-15 18:08:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
335562bcfde6e44c18f0ca7311d75905b18fc603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698