Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1060013003: [release-tools] Only read from the chromium checkout in v8rel. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release-tools] Only read from the chromium checkout in v8rel. Don't create local branches or otherwise manipulate the checkout. This reads refs from remote branches and reads file contents using show. It is faster and requires less bootstrapping and cleanup. TBR=tandrii@chromium.org NOTRY=true Committed: https://crrev.com/3449e4f833590fd6f1548be53be8c1b84e187942 Cr-Commit-Position: refs/heads/master@{#27640}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -83 lines) Patch
M tools/release/git_recipes.py View 3 chunks +10 lines, -3 lines 1 comment Download
M tools/release/releases.py View 10 chunks +13 lines, -43 lines 3 comments Download
M tools/release/test_scripts.py View 4 chunks +9 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py#newcode363 tools/release/releases.py:363: if count_past_last_v8 > 20: 10 was a bit ...
5 years, 8 months ago (2015-04-07 14:21:15 UTC) #2
tandrii(chromium)
lgtm https://codereview.chromium.org/1060013003/diff/1/tools/release/git_recipes.py File tools/release/git_recipes.py (right): https://codereview.chromium.org/1060013003/diff/1/tools/release/git_recipes.py#newcode183 tools/release/git_recipes.py:183: args.extend(["--", path]) nice! https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py#newcode494 ...
5 years, 8 months ago (2015-04-07 15:13:51 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/1060013003/diff/1/tools/release/releases.py#newcode494 tools/release/releases.py:494: RietrieveChromiumBranches, On 2015/04/07 15:13:51, tandrii(chromium) wrote: > unrelated CL ...
5 years, 8 months ago (2015-04-07 19:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060013003/1
5 years, 8 months ago (2015-04-07 19:42:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 19:42:40 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:42:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3449e4f833590fd6f1548be53be8c1b84e187942
Cr-Commit-Position: refs/heads/master@{#27640}

Powered by Google App Engine
This is Rietveld 408576698