Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1059993002: [New Tab Page] Local NTP: bound the size of favicon image. (Closed)

Created:
5 years, 8 months ago by huangs
Modified:
5 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, Mathieu, fserb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[New Tab Page] Local NTP: bound the size of favicon image. Applied to the old NTP and the fast NTP. Otherwise server-injected favicon that's bigger than 16x16 will overflow. BUG=474102 Committed: https://crrev.com/a41990641a23ad8738881e4731022472135b2e0c Cr-Commit-Position: refs/heads/master@{#324045}

Patch Set 1 #

Patch Set 2 : Code movement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
huangs
Small CSS change, but we need to merge this into M43. PTAL.
5 years, 8 months ago (2015-04-06 04:11:47 UTC) #2
huangs
Holiday in Canada, so changing reviewer to samarth@. PTAL.
5 years, 8 months ago (2015-04-06 17:59:34 UTC) #4
Mathieu
lgtm
5 years, 8 months ago (2015-04-07 13:32:21 UTC) #6
huangs
Thanks! Submitting.
5 years, 8 months ago (2015-04-07 13:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059993002/20001
5 years, 8 months ago (2015-04-07 13:41:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 15:21:16 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:22:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a41990641a23ad8738881e4731022472135b2e0c
Cr-Commit-Position: refs/heads/master@{#324045}

Powered by Google App Engine
This is Rietveld 408576698