Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1059963006: Change a data_deps to deps temporarily since it doesn't seem to be working transitively. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change a data_deps to deps temporarily since it doesn't seem to be working transitively. The "mojo" target depended on //ui/gl:gl transitively through a few dependencies. However when building it, libEGL etc don't get built. This works with deps but not data_deps. BUG=477104 Committed: https://crrev.com/f7986b663e1132e9e83f95391ba99c99c338eccf Cr-Commit-Position: refs/heads/master@{#325506}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/gl/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
5 years, 8 months ago (2015-04-16 19:26:57 UTC) #2
brettw
lgtm https://codereview.chromium.org/1059963006/diff/1/ui/gl/BUILD.gn File ui/gl/BUILD.gn (right): https://codereview.chromium.org/1059963006/diff/1/ui/gl/BUILD.gn#newcode203 ui/gl/BUILD.gn:203: deps += [ Can you put "# TODO(brettw) ...
5 years, 8 months ago (2015-04-16 19:33:30 UTC) #3
jam
https://codereview.chromium.org/1059963006/diff/1/ui/gl/BUILD.gn File ui/gl/BUILD.gn (right): https://codereview.chromium.org/1059963006/diff/1/ui/gl/BUILD.gn#newcode203 ui/gl/BUILD.gn:203: deps += [ On 2015/04/16 19:33:30, brettw wrote: > ...
5 years, 8 months ago (2015-04-16 20:01:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059963006/20001
5 years, 8 months ago (2015-04-16 20:03:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 20:28:13 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 20:29:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7986b663e1132e9e83f95391ba99c99c338eccf
Cr-Commit-Position: refs/heads/master@{#325506}

Powered by Google App Engine
This is Rietveld 408576698