Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1059903004: [heap] Assert that code objects are always properly aligned. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Hannes Payer (out of office)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Assert that code objects are always properly aligned. R=mstarzinger@chromium.org Committed: https://crrev.com/5169481644c7998bc59e657e35f220ed94aa625a Cr-Commit-Position: refs/heads/master@{#27621}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Michis comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap/heap.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-07 10:46:43 UTC) #1
Benedikt Meurer
Michi: PTAL Hannes: FYI
5 years, 8 months ago (2015-04-07 10:47:37 UTC) #2
Michael Starzinger
LGTM with comment. https://codereview.chromium.org/1059903004/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1059903004/diff/1/src/heap/heap.cc#newcode3830 src/heap/heap.cc:3830: // Relocate the copy. Please also ...
5 years, 8 months ago (2015-04-07 10:51:06 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1059903004/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1059903004/diff/1/src/heap/heap.cc#newcode3830 src/heap/heap.cc:3830: // Relocate the copy. On 2015/04/07 10:51:05, Michael Starzinger ...
5 years, 8 months ago (2015-04-07 10:53:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059903004/20001
5 years, 8 months ago (2015-04-07 10:53:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 11:24:21 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 11:24:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5169481644c7998bc59e657e35f220ed94aa625a
Cr-Commit-Position: refs/heads/master@{#27621}

Powered by Google App Engine
This is Rietveld 408576698