Allow Alt-Tab to move the focus to docked windows.

ash/wm/overview/window_selector_controller.cc

Index: ash/wm/overview/window_selector_controller.cc
diff --git a/ash/wm/overview/window_selector_controller.cc b/ash/wm/overview/window_selector_controller.cc
index df14d27e87c57fb4b8b912d3c195b48d7583c553..582372ce6dc5afdc761f86e039aa4f998a1eacdf 100644
--- a/ash/wm/overview/window_selector_controller.cc
+++ b/ash/wm/overview/window_selector_controller.cc
@@ -46,8 +46,17 @@ void WindowSelectorController::ToggleOverview() {
     if (!CanSelect())
       return;
 
-    std::vector<aura::Window*> windows = ash::Shell::GetInstance()->
-        mru_window_tracker()->BuildMruWindowList();
+    aura::Window::Windows windows =
+        ash::Shell::GetInstance()->mru_window_tracker()->BuildMruWindowList();
+
+    for (aura::Window::Windows::iterator iter = windows.begin();

[flackr, 2015/04/07 15:08:39]

Use std::remove_if for linear runtime?

[oshima, 2015/04/07 18:00:32]

This is linear too. To use remove_if, I need to change IsSelectable to
IsNotSelectable, or define functor. Please let me know if you prefer remove_if,
and I'll update the code.

[flackr, 2015/04/07 18:10:33]

aura::Window::Windows looks to be a vector making each erase(iter) operation
linear time so for lots of docked windows this would become quadratic wouldn't
it?

[oshima, 2015/04/07 20:35:29]

You're absolutely right, sorry. Updated.

+         iter != windows.end();) {
+      if (WindowSelector::IsSelectable(*iter))
+        ++iter;
+      else
+        iter = windows.erase(iter);
+    }
+
     // Don't enter overview mode with no windows.
     if (windows.empty())
       return;