Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1059873002: Tweaks to warning level and reporting (Closed)

Created:
5 years, 8 months ago by vsm
Modified:
5 years, 8 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix up tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -38 lines) Patch
M lib/src/codegen/reify_coercions.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/info.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M lib/src/report.dart View 1 4 chunks +9 lines, -4 lines 0 comments Download
M test/checker/checker_test.dart View 1 4 chunks +10 lines, -10 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/cascade.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/fieldtest.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/methods.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 8 months ago (2015-04-03 22:25:57 UTC) #2
Leaf
lgtm
5 years, 8 months ago (2015-04-03 22:36:12 UTC) #3
vsm
5 years, 8 months ago (2015-04-03 22:47:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d44db6aff768adae6ac4e41ce9df620a83147f84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698