Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1059863002: Upstream the last native calls in the Application. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream the last native calls in the Application. Move ChangeAppStatus() and RemoveSessionCookies() calls to ChromiumApplication. BUG=None Committed: https://crrev.com/0e5f381468c138153f294b746a9b36a2bc9b75f2 Cr-Commit-Position: refs/heads/master@{#323843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java View 3 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/android/chromium_application.cc View 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aurimas (slooooooooow)
newt: PTAL
5 years, 8 months ago (2015-04-03 21:54:23 UTC) #2
newt (away)
no code changes to the methods you've upstreamed? if so, lgtm
5 years, 8 months ago (2015-04-03 22:26:42 UTC) #3
aurimas (slooooooooow)
On 2015/04/03 at 22:26:42, newt wrote: > no code changes to the methods you've upstreamed? ...
5 years, 8 months ago (2015-04-03 22:27:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059863002/1
5 years, 8 months ago (2015-04-03 22:28:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 22:56:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:56:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e5f381468c138153f294b746a9b36a2bc9b75f2
Cr-Commit-Position: refs/heads/master@{#323843}

Powered by Google App Engine
This is Rietveld 408576698