Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1059853004: Reland "Remove support for thread-based recompilation" (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Remove support for thread-based recompilation" Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > Cr-Commit-Position: refs/heads/master@{#27619} BUG=v8:3608 R=yangguo@chromium.org LOG=y Committed: https://crrev.com/f1ceccb8b8b352a91e6366e3e3103f1db0df6afb Cr-Commit-Position: refs/heads/master@{#27813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -885 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/isolate.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/optimizing-compile-dispatcher.h View 9 chunks +17 lines, -44 lines 0 comments Download
A + src/optimizing-compile-dispatcher.cc View 18 chunks +59 lines, -171 lines 0 comments Download
D src/optimizing-compiler-thread.h View 1 chunk +0 lines, -166 lines 0 comments Download
D src/optimizing-compiler-thread.cc View 1 chunk +0 lines, -463 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
rubberstamp lgtm.
5 years, 8 months ago (2015-04-14 10:00:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059853004/1
5 years, 8 months ago (2015-04-14 10:00:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 10:26:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1ceccb8b8b352a91e6366e3e3103f1db0df6afb Cr-Commit-Position: refs/heads/master@{#27813}
5 years, 8 months ago (2015-04-14 10:27:00 UTC) #5
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-14 12:29:04 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1082183003/ by jochen@chromium.org.

The reason for reverting is: still times out.

Powered by Google App Engine
This is Rietveld 408576698