components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 1059843002: Refactor NetLog::LogLevel --> NetLogCaptureMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 1059843002: Refactor NetLog::LogLevel --> NetLogCaptureMode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing header Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_net_log.cc ('K') | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java » ('j') | components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index f0207ec822c77549706197060b93ad19e373af9a..03246f4ac7db3c5c78199ed631f026a84e52d9c6 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -77,8 +77,8 @@ public class ChromiumUrlRequestContext {

}

/**

- * Starts NetLog logging to a file. The NetLog log level used is

- * LOG_ALL_BUT_BYTES.

+ * Starts NetLog logging to a file. The NetLog capture mode is

+ * NetLogCaptureMode::Default().

mmenke 2015/04/22 18:52:17 IncludeCookiesAndCredentials(). But no cake. :(

eroman 2015/04/22 20:01:47 Actually this was intentional -- the existing comm

mmenke 2015/04/22 20:08:35 Ahh, right. I thought I checked by that by lookin

* @param fileName The complete file path. It must not be empty. If file

* exists, it is truncated before starting. If actively logging,

* this method is ignored.