chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc - Issue 1059843002: Refactor NetLog::LogLevel --> NetLogCaptureMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

Issue 1059843002: Refactor NetLog::LogLevel --> NetLogCaptureMode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add header for std::max Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

index 582fe12603f9e3ab7a6959d8a5fddeaa10e13849..e243f4bf38cf8617dc8f058a47bd996f02b70c50 100644

--- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

@@ -288,7 +288,8 @@ void LogPrivateAPI::StartObservingNetEvents(

return;

net_log_logger_.reset(new net::NetLogLogger());

- net_log_logger_->set_log_level(net::NetLog::LOG_ALL_BUT_BYTES);

+ net_log_logger_->set_capture_mode(

+ net::NetLogCaptureMode::IncludeCookiesAndCredentials());

net_log_logger_->StartObserving(io_thread->net_log(), file->Pass(), nullptr,

nullptr);

}

@@ -304,7 +305,7 @@ void LogPrivateAPI::MaybeStartNetInternalLogging(

switch (event_sink_) {

case api::log_private::EVENT_SINK_CAPTURE: {

io_thread->net_log()->DeprecatedAddObserver(

- this, net::NetLog::LOG_ALL_BUT_BYTES);

+ this, net::NetLogCaptureMode::IncludeCookiesAndCredentials());

break;

}

case api::log_private::EVENT_SINK_FILE: {

« no previous file with comments | « no previous file | chrome/browser/net/chrome_net_log.cc » ('j') | net/log/net_log_capture_mode.h » ('J')