Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1059793002: bluetooth: Move Bluetooth-related Blink API headers into their own directory. (Closed)

Created:
5 years, 8 months ago by ortuno
Modified:
5 years, 8 months ago
Reviewers:
scheib, Nate Chapin
CC:
abarth-chromium, blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Move Bluetooth-related Blink API headers into their own directory. This allows the Bluetooth APIs to be covered by a bluetooth OWNER on top of the other public/ OWNERS. This is part of a three-sided patch: [1] This patch. [2] https://codereview.chromium.org/1059753003 [3] https://codereview.chromium.org/1060643002 BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193653

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : bluetooth: Move Bluetooth-related Blink API headers into their own directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -114 lines) Patch
M Source/modules/bluetooth/BluetoothDevice.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothDiscovery.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothError.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebBluetooth.h View 1 2 3 1 chunk +2 lines, -26 lines 0 comments Download
M public/platform/WebBluetoothDevice.h View 1 2 3 1 chunk +2 lines, -55 lines 0 comments Download
M public/platform/WebBluetoothError.h View 1 2 3 1 chunk +2 lines, -28 lines 0 comments Download
A public/platform/modules/bluetooth/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + public/platform/modules/bluetooth/WebBluetooth.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/bluetooth/WebBluetoothDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + public/platform/modules/bluetooth/WebBluetoothError.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ortuno
Please review scheib@
5 years, 8 months ago (2015-04-03 20:34:15 UTC) #2
scheib
LGTM, though please add TODOs https://codereview.chromium.org/1059793002/diff/40001/public/platform/WebBluetooth.h File public/platform/WebBluetooth.h (right): https://codereview.chromium.org/1059793002/diff/40001/public/platform/WebBluetooth.h#newcode5 public/platform/WebBluetooth.h:5: #include "public/platform/modules/bluetooth/WebBluetooth.h" Leave a ...
5 years, 8 months ago (2015-04-13 17:46:34 UTC) #3
ortuno
Please review @japhet
5 years, 8 months ago (2015-04-13 17:55:49 UTC) #5
Nate Chapin
lgtm
5 years, 8 months ago (2015-04-13 19:16:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059793002/60001
5 years, 8 months ago (2015-04-13 19:17:48 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 21:22:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193653

Powered by Google App Engine
This is Rietveld 408576698