Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1059743004: Teach window.location.href setter to handle relative urls. (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach window.location.href setter to handle relative urls. Also fixed display of text in touch-demo.sky R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/69ceb794dbc381546adb0c3cc70b3d58cc497bd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/touch-demo.sky View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 8 months ago (2015-04-14 19:15:01 UTC) #1
Hixie
lgtm
5 years, 8 months ago (2015-04-14 19:16:43 UTC) #2
eseidel
5 years, 8 months ago (2015-04-14 19:16:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69ceb794dbc381546adb0c3cc70b3d58cc497bd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698