Source/core/page/FocusController.cpp - Issue 105973003: Improve spatial navigation on overlapping elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.cpp

Issue 105973003: Improve spatial navigation on overlapping elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/spatial-navigation/snav-overlapping-elements.html ('K') | « LayoutTests/fast/spatial-navigation/snav-overlapping-elements-expected.txt ('k') | Source/core/page/SpatialNavigation.cpp » ('j') | Source/core/page/SpatialNavigation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/FocusController.cpp

diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp

index be1d745fb6311e48401069eccf40756d374e5fff..d9d382fec88b631f5b40adc22e8ac1672624748f 100644

--- a/Source/core/page/FocusController.cpp

+++ b/Source/core/page/FocusController.cpp

@@ -744,7 +744,8 @@ static void updateFocusCandidateIfNeeded(FocusDirection direction, const FocusCa

}

LayoutRect intersectionRect = intersection(candidate.rect, closest.rect);

- if (!intersectionRect.isEmpty() && !areElementsOnSameLine(closest, candidate)) {

+ if (!intersectionRect.isEmpty() && !areElementsOnSameLine(closest, candidate)

+ && intersectionRect == candidate.rect) {

// If 2 nodes are intersecting, do hit test to find which node in on top.

LayoutUnit x = intersectionRect.x() + intersectionRect.width() / 2;

LayoutUnit y = intersectionRect.y() + intersectionRect.height() / 2;