Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: mojo/edk/embedder/scoped_platform_handle.h

Issue 1059663002: Use newer Chromium helper macro for defining move-only type. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Add self-assignment check in move assignment operator. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_ 5 #ifndef MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_
6 #define MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_ 6 #define MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/move.h" 9 #include "base/move.h"
10 #include "mojo/edk/embedder/platform_handle.h" 10 #include "mojo/edk/embedder/platform_handle.h"
11 #include "mojo/edk/system/system_impl_export.h" 11 #include "mojo/edk/system/system_impl_export.h"
12 12
13 namespace mojo { 13 namespace mojo {
14 namespace embedder { 14 namespace embedder {
15 15
16 class MOJO_SYSTEM_IMPL_EXPORT ScopedPlatformHandle { 16 class MOJO_SYSTEM_IMPL_EXPORT ScopedPlatformHandle {
17 MOVE_ONLY_TYPE_FOR_CPP_03(ScopedPlatformHandle, RValue) 17 MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03(ScopedPlatformHandle)
18 18
19 public: 19 public:
20 ScopedPlatformHandle() {} 20 ScopedPlatformHandle() {}
21 explicit ScopedPlatformHandle(PlatformHandle handle) : handle_(handle) {} 21 explicit ScopedPlatformHandle(PlatformHandle handle) : handle_(handle) {}
22 ~ScopedPlatformHandle() { handle_.CloseIfNecessary(); } 22 ~ScopedPlatformHandle() { handle_.CloseIfNecessary(); }
23 23
24 // Move-only constructor and operator=. 24 // Move-only constructor and operator=.
25 ScopedPlatformHandle(RValue other) : handle_(other.object->release()) {} 25 ScopedPlatformHandle(ScopedPlatformHandle&& other)
26 ScopedPlatformHandle& operator=(RValue other) { 26 : handle_(other.release()) {}
27 handle_ = other.object->release(); 27
28 ScopedPlatformHandle& operator=(ScopedPlatformHandle&& other) {
29 if (this != &other) {
viettrungluu 2015/04/03 19:36:51 nit: for consistency with surrounding code, please
mgraczyk 2015/04/03 19:44:27 Done.
30 handle_ = other.release();
31 }
28 return *this; 32 return *this;
29 } 33 }
30 34
31 const PlatformHandle& get() const { return handle_; } 35 const PlatformHandle& get() const { return handle_; }
32 36
33 void swap(ScopedPlatformHandle& other) { 37 void swap(ScopedPlatformHandle& other) {
34 PlatformHandle temp = handle_; 38 PlatformHandle temp = handle_;
35 handle_ = other.handle_; 39 handle_ = other.handle_;
36 other.handle_ = temp; 40 other.handle_ = temp;
37 } 41 }
(...skipping 12 matching lines...) Expand all
50 bool is_valid() const { return handle_.is_valid(); } 54 bool is_valid() const { return handle_.is_valid(); }
51 55
52 private: 56 private:
53 PlatformHandle handle_; 57 PlatformHandle handle_;
54 }; 58 };
55 59
56 } // namespace embedder 60 } // namespace embedder
57 } // namespace mojo 61 } // namespace mojo
58 62
59 #endif // MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_ 63 #endif // MOJO_EDK_EMBEDDER_SCOPED_PLATFORM_HANDLE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698