test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart - Issue 1059583002: Extension method support to move us closer to a valid List implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart

Issue 1059583002: Extension method support to move us closer to a valid List implementation. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/src/codegen/js_codegen.dart ('K') | « test/dart_codegen/expect/core/list.dart ('k') | test/generated_sdk/lib/core/annotations.dart » ('j') | test/generated_sdk/lib/core/annotations.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart

diff --git a/test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart b/test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart

index 615ed61fbd31e254f2294e5553171d3104e14e7d..c9aab5f74eea2f6acccabea2f56a094e5e2916cd 100644

--- a/test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart

+++ b/test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart

@@ -10,7 +10,8 @@ part of _interceptors;

* actually use the receiver of the method, which is generated as an extra

* argument added to each member.

-class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

+@JsName(name: 'Array')

+class JSArray<E> implements List<E>, JSIndexable {

const JSArray();