lib/runtime/dart/isolate.js - Issue 1059583002: Extension method support to move us closer to a valid List implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/isolate.js

Issue 1059583002: Extension method support to move us closer to a valid List implementation. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/runtime/dart/isolate.js

diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js

index c5a509a390c9c143146aff040f83c4d55e1418ab..35c00f40dc2a02e56d6e38188bd4659a68ef0394 100644

--- a/lib/runtime/dart/isolate.js

+++ b/lib/runtime/dart/isolate.js

@@ -45,8 +45,8 @@ var isolate;

throw new core.UnimplementedError("packageRoot");

try {

if (dart.is(args, core.List$(core.String))) {

- for (let i = 0; dart.notNull(i) < dart.notNull(args.length); i = dart.notNull(i) + 1) {

- if (!(typeof args.get(i) == 'string')) {

+ for (let i = 0; dart.notNull(i) < dart.notNull(args[core.$length]); i = dart.notNull(i) + 1) {

+ if (!(typeof args[core.$get](i) == 'string')) {

throw new core.ArgumentError(`Args must be a list of Strings ${args}`);

}

« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | lib/src/codegen/js_codegen.dart » ('J')