Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: test/codegen/expect/BenchmarkBase.js

Issue 1059583002: Extension method support to move us closer to a valid List implementation. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: done Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/DeltaBlue.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/expect/BenchmarkBase.js
diff --git a/test/codegen/expect/BenchmarkBase.js b/test/codegen/expect/BenchmarkBase.js
index 63ae85f53518446ea36ac19bd7b7f6eea0f8b35b..71be5564365528022c5691281c7b2dedb468689c 100644
--- a/test/codegen/expect/BenchmarkBase.js
+++ b/test/codegen/expect/BenchmarkBase.js
@@ -8,11 +8,11 @@ var BenchmarkBase;
}
}
static listEquals(expected, actual) {
- if (expected.length != actual.length) {
- throw `Lists have different lengths: ${expected.length} vs ${actual.length}`;
+ if (expected[core.$length] != actual[core.$length]) {
+ throw `Lists have different lengths: ${expected[core.$length]} vs ${actual[core.$length]}`;
}
- for (let i = 0; dart.notNull(i) < dart.notNull(actual.length); i = dart.notNull(i) + 1) {
- Expect.equals(expected.get(i), actual.get(i));
+ for (let i = 0; dart.notNull(i) < dart.notNull(actual[core.$length]); i = dart.notNull(i) + 1) {
+ Expect.equals(expected[core.$get](i), actual[core.$get](i));
}
}
fail(message) {
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/DeltaBlue.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698