Chromium Code Reviews| Index: src/extensions/trigger-failure-extension.h |
| diff --git a/src/extensions/free-buffer-extension.h b/src/extensions/trigger-failure-extension.h |
| similarity index 74% |
| copy from src/extensions/free-buffer-extension.h |
| copy to src/extensions/trigger-failure-extension.h |
| index 22d466f61e02b4e8367dfc9d06f00095aa5efe02..0659c200495718e0fba3d4fdbbff221a683ceac9 100644 |
| --- a/src/extensions/free-buffer-extension.h |
| +++ b/src/extensions/trigger-failure-extension.h |
| @@ -25,25 +25,32 @@ |
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| -#ifndef V8_EXTENSIONS_FREE_BUFFER_EXTENSION_H_ |
| -#define V8_EXTENSIONS_FREE_BUFFER_EXTENSION_H_ |
| +#ifndef V8_EXTENSIONS_TRIGGER_FAILURE_EXTENSION_H_ |
| +#define V8_EXTENSIONS_TRIGGER_FAILURE_EXTENSION_H_ |
| #include "v8.h" |
| namespace v8 { |
| namespace internal { |
| -class FreeBufferExtension : public v8::Extension { |
| +class TriggerFailureExtension : public v8::Extension { |
| public: |
| - explicit FreeBufferExtension(const char* source) |
| - : v8::Extension("v8/free-buffer", source) {} |
| + explicit TriggerFailureExtension() |
|
Jakob Kummerow
2013/12/05 16:13:34
nit: no "explicit" for zero-argument constructors
Michael Achenbach
2013/12/05 16:16:40
Done.
|
| + : v8::Extension("v8/trigger-failure", kSource) {} |
| virtual v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate( |
| v8::Isolate* isolate, |
| v8::Handle<v8::String> name); |
| - static void FreeBuffer(const v8::FunctionCallbackInfo<v8::Value>& args); |
| + static void TriggerCheckFalse( |
| + const v8::FunctionCallbackInfo<v8::Value>& args); |
| + static void TriggerAssertFalse( |
| + const v8::FunctionCallbackInfo<v8::Value>& args); |
| + static void TriggerSlowAssertFalse( |
| + const v8::FunctionCallbackInfo<v8::Value>& args); |
| static void Register(); |
| + private: |
|
Jakob Kummerow
2013/12/05 16:13:34
nit: empty line before "private:"
Michael Achenbach
2013/12/05 16:16:40
Done.
|
| + static const char* const kSource; |
| }; |
| } } // namespace v8::internal |
| -#endif // V8_EXTENSIONS_FREE_BUFFER_EXTENSION_H_ |
| +#endif // V8_EXTENSIONS_TRIGGER_FAILURE_EXTENSION_H_ |