Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 105953005: Add tests and extension verifying CHECK and ASSERT. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Add tests and extension verifying CHECK and ASSERT. The new native functions can also be used in blink tests to ensure that V8 asserts are turned on where they should be. BUG= R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18262

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -24 lines) Patch
M src/bootstrapper.cc View 3 chunks +6 lines, -1 line 0 comments Download
A + src/extensions/trigger-failure-extension.h View 1 1 chunk +14 lines, -7 lines 0 comments Download
A + src/extensions/trigger-failure-extension.cc View 1 chunk +36 lines, -14 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/verify-assert-false.js View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/verify-check-false.js View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-12-05 16:04:44 UTC) #1
Jakob Kummerow
DBC. https://codereview.chromium.org/105953005/diff/60001/src/extensions/trigger-failure-extension.h File src/extensions/trigger-failure-extension.h (right): https://codereview.chromium.org/105953005/diff/60001/src/extensions/trigger-failure-extension.h#newcode38 src/extensions/trigger-failure-extension.h:38: explicit TriggerFailureExtension() nit: no "explicit" for zero-argument constructors ...
7 years ago (2013-12-05 16:13:34 UTC) #2
Michael Achenbach
https://codereview.chromium.org/105953005/diff/60001/src/extensions/trigger-failure-extension.h File src/extensions/trigger-failure-extension.h (right): https://codereview.chromium.org/105953005/diff/60001/src/extensions/trigger-failure-extension.h#newcode38 src/extensions/trigger-failure-extension.h:38: explicit TriggerFailureExtension() On 2013/12/05 16:13:34, Jakob wrote: > nit: ...
7 years ago (2013-12-05 16:16:39 UTC) #3
Dmitry Lomov (no reviews)
lgtm Will be nice to have a test that verifies SLOW_ASSERT as well, but ok ...
7 years ago (2013-12-05 16:49:40 UTC) #4
Michael Achenbach
7 years ago (2013-12-05 17:26:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18262.

Powered by Google App Engine
This is Rietveld 408576698