Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1059523005: Remove dependency on //chrome from bookmark_undo_utils (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger, sky
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on //chrome from bookmark_undo_utils Change ScopedSuspendBookmarkUndo to take the BookmarkUndoService instead of the Profile in its constructor and change client code accordingly. Add a GetProfileIfExists() method to BookmarkUndoServiceFactory to avoid service creation when suspending the undo/redo mechanism as if the service is initialized at BookmarkModel creation time. BUG=477679 Committed: https://crrev.com/712151c66a78141f6ef78f20c9425c915f5964d3 Cr-Commit-Position: refs/heads/master@{#325463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/undo/bookmark_undo_service_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service_factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_utils.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_utils.cc View 1 chunk +9 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
droger: please review sky: OWNERS review
5 years, 8 months ago (2015-04-16 14:02:01 UTC) #2
droger
lgtm
5 years, 8 months ago (2015-04-16 14:12:53 UTC) #3
sky
LGTM
5 years, 8 months ago (2015-04-16 16:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059523005/1
5 years, 8 months ago (2015-04-16 16:47:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 17:23:20 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:24:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712151c66a78141f6ef78f20c9425c915f5964d3
Cr-Commit-Position: refs/heads/master@{#325463}

Powered by Google App Engine
This is Rietveld 408576698