Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1059523004: Removing unused function WTF::appendNumber (Closed)

Created:
5 years, 8 months ago by Daniel Bratell
Modified:
5 years, 8 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused function WTF::appendNumber WTF::appendNumber can append a number as decimal characters to a Vector of things that accept characters. It is not a string method and nobody is using it so we have no reason to keep it. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M Source/wtf/text/WTFString.h View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Daniel Bratell
jochen, here is your easiest review of the week.
5 years, 8 months ago (2015-04-10 15:10:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-13 12:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059523004/1
5 years, 8 months ago (2015-04-13 12:27:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/57172)
5 years, 8 months ago (2015-04-13 17:20:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059523004/1
5 years, 8 months ago (2015-04-14 07:23:17 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 08:45:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193677

Powered by Google App Engine
This is Rietveld 408576698