Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 1059503003: Enable 2 pending frames on ARM devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
index 8e7b07e71ee9b341fc7eed9e990d5c8cebb47844..68ceee55b6babacbb94456d10d2c6f2caea3cb46 100644
--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
@@ -30,12 +30,14 @@ GpuSurfacelessBrowserCompositorOutputSurface::
gpu_memory_buffer_manager_(gpu_memory_buffer_manager) {
capabilities_.uses_default_gl_framebuffer = false;
capabilities_.flipped_output_surface = true;
- // TODO(alexst): Can't enable this on ARM since it hangs the device
- // (crbug.com/470185). Alternatively remove this entirely once the compositor
- // scheduling is optimized enough to work well with surfaceless.
-#if defined(ARCH_CPU_X86_FAMILY)
+ // Set |max_frames_pending| to 2 for surfaceless, which aligns scheduling
+ // more closely with the previous surfaced behavior.
+ // With a surface, swap buffer ack used to return early, before actually
+ // presenting the back buffer, enabling the browser compositor to run ahead.
+ // Surfaceless implementation acks at the time of actual buffer swap, which
+ // shifts the start of the new frame forward relative to the old
+ // implementation.
capabilities_.max_frames_pending = 2;
-#endif
gl_helper_.reset(new GLHelper(context_provider_->ContextGL(),
context_provider_->ContextSupport()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698