Source/modules/accessibility/AXMenuList.cpp - Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuList.cpp

Issue 1059503002: Re-land: Don't keep recreating AXMenuListPopup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@suppress_extra_events

Patch Set: Fix optgroup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXMenuList.cpp

diff --git a/Source/modules/accessibility/AXMenuList.cpp b/Source/modules/accessibility/AXMenuList.cpp

index 6e7b9029e772a95f4086403772897897586fbb47..f21b0f6f5b083b96af8c27e1257e7432f9a90ec6 100644

--- a/Source/modules/accessibility/AXMenuList.cpp

+++ b/Source/modules/accessibility/AXMenuList.cpp

@@ -93,15 +93,6 @@ void AXMenuList::addChildren()

list->addChildren();

}

-void AXMenuList::childrenChanged()

- if (m_children.isEmpty())

- return;

- ASSERT(m_children.size() == 1);

- m_children[0]->childrenChanged();

bool AXMenuList::isCollapsed() const

{

return !toLayoutMenuList(m_layoutObject)->popupIsVisible();

« no previous file with comments | « Source/modules/accessibility/AXMenuList.h ('k') | Source/modules/accessibility/AXMenuListOption.h » ('j') | no next file with comments »