Re-land: Don't keep recreating AXMenuListPopup

Source/modules/accessibility/AXMenuListOption.h

 /*
  * Copyright (C) 2010 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AXMenuListOption_h
 #define AXMenuListOption_h
 
+#include "core/html/HTMLOptionElement.h"
 #include "modules/accessibility/AXMockObject.h"
 
 namespace blink {
 
 class AXObjectCacheImpl;
-class HTMLElement;
 
 class AXMenuListOption final : public AXMockObject {
 public:
-    static PassRefPtr<AXMenuListOption> create(AXObjectCacheImpl* axObjectCache) { return adoptRef(new AXMenuListOption(axObjectCache)); }
-
-    void setElement(HTMLElement*);
+    static PassRefPtr<AXMenuListOption> create(HTMLOptionElement* element, AXObjectCacheImpl* axObjectCache) { return adoptRef(new AXMenuListOption(element, axObjectCache)); }
 
 private:
-    explicit AXMenuListOption(AXObjectCacheImpl*);
+    explicit AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl*);
 
     virtual bool isMenuListOption() const override { return true; }
 
+    virtual Node* node() const override { return m_element; }
+    virtual void detach() override;
+    virtual bool isDetached() const override { return !m_element; }
     virtual AccessibilityRole roleValue() const override { return MenuListOptionRole; }
     virtual bool canHaveChildren() const override { return false; }
 
     virtual Element* actionElement() const override;
     virtual bool isEnabled() const override;
     virtual bool isVisible() const override;
     virtual bool isOffScreen() const override;
     virtual bool isSelected() const override;
     virtual void setSelected(bool) override;
     virtual bool canSetSelectedAttribute() const override;
     virtual LayoutRect elementRect() const override;
     virtual String stringValue() const override;
     virtual bool computeAccessibilityIsIgnored() const override;
 
-    RefPtrWillBePersistent<HTMLElement> m_element;
+    HTMLOptionElement* m_element;
 };
 
 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, isMenuListOption());
 
 } // namespace blink
 
 #endif // AXMenuListOption_h