Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1059453003: Revert of Respect prefs::kAllowDeletingBrowserHistory in the Clear History UI on Android. (Closed)

Created:
5 years, 8 months ago by knn
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Respect prefs::kAllowDeletingBrowserHistory in the Clear History UI on Android. (patchset #7 id:110001 of https://codereview.chromium.org/974463002/) Reason for revert: Need to investigate AlertDialog's getListView method when a custom view is added to it. Original issue's description: > Respect prefs::kAllowDeletingBrowserHistory in the Clear History UI on Android. > > BUG=443095 > > Committed: https://crrev.com/935a20a1398e28ba5ec3298ae97c941810e618c0 > Cr-Commit-Position: refs/heads/master@{#319618} TBR=bauerb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=443095 Committed: https://crrev.com/6effee7ce16454e78f8b4d2c8e80886ac8c72d5d Cr-Commit-Position: refs/heads/master@{#323534}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -40 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataDialogFragment.java View 1 5 chunks +4 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
knn
Created Revert of Respect prefs::kAllowDeletingBrowserHistory in the Clear History UI on Android.
5 years, 8 months ago (2015-04-02 17:11:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059453003/120001
5 years, 8 months ago (2015-04-02 17:37:35 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-02 17:37:37 UTC) #6
kerz_chromium
On 2015/04/02 17:37:37, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 8 months ago (2015-04-02 17:38:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059453003/120001
5 years, 8 months ago (2015-04-02 17:39:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 8 months ago (2015-04-02 17:41:19 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:27:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6effee7ce16454e78f8b4d2c8e80886ac8c72d5d
Cr-Commit-Position: refs/heads/master@{#323534}

Powered by Google App Engine
This is Rietveld 408576698