Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8129)

Unified Diff: build/android/pylib/screenshot.py

Issue 1059443005: Revert of [Android] Reland cleanup of old_interface in build/android/pylib. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf/test_runner.py ('k') | build/android/pylib/uiautomator/test_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/screenshot.py
diff --git a/build/android/pylib/screenshot.py b/build/android/pylib/screenshot.py
index 2704631d0244e68628489b394e0efafd7ec92b23..e21d7560b6e5854193362701e91d7935073fca60 100644
--- a/build/android/pylib/screenshot.py
+++ b/build/android/pylib/screenshot.py
@@ -5,7 +5,6 @@
import os
import signal
import tempfile
-import time
from pylib import cmd_helper
@@ -83,13 +82,10 @@ class VideoRecorder(object):
Returns:
Output video file name on the host.
"""
- # TODO(jbudorick): Merge filename generation with the logic for doing so in
- # DeviceUtils.
- host_file_name = (
- host_file
- or 'screen-recording-%s.mp4' % time.strftime('%Y%m%dT%H%M%S',
- time.localtime()))
+ host_file_name = host_file or ('screen-recording-%s.mp4' %
+ self._device.old_interface.GetTimestamp())
host_file_name = os.path.abspath(host_file_name)
+ self._device.old_interface.EnsureHostDirectory(host_file_name)
self._device.PullFile(self._device_file, host_file_name)
self._device.RunShellCommand('rm -f "%s"' % self._device_file)
return host_file_name
« no previous file with comments | « build/android/pylib/perf/test_runner.py ('k') | build/android/pylib/uiautomator/test_options.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698