Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1059443005: Revert of [Android] Reland cleanup of old_interface in build/android/pylib. (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 8 months ago
Reviewers:
klundberg, perezju
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Reland cleanup of old_interface in build/android/pylib. (patchset #2 id:20001 of https://codereview.chromium.org/1050883002/) Reason for revert: Broke the perf bots again. Original issue's description: > [Android] Reland cleanup of old_interface in build/android/pylib. > > Original CL: https://codereview.chromium.org/1047703002/ > > BUG=267773 TBR=klundberg@chromium.org,perezju@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/bd6b7ec8c71da55fc79039374af97f77e5b2051b Cr-Commit-Position: refs/heads/master@{#323573}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -77 lines) Patch
M build/android/pylib/base/base_test_runner.py View 1 3 chunks +5 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 chunks +0 lines, -18 lines 0 comments Download
M build/android/pylib/gtest/test_options.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 2 chunks +8 lines, -14 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/setup.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_case.py View 1 2 chunks +6 lines, -1 line 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 2 chunks +4 lines, -8 lines 0 comments Download
M build/android/pylib/instrumentation/test_options.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/linker/setup.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/linker/test_runner.py View 1 2 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/screenshot.py View 1 2 chunks +3 lines, -7 lines 0 comments Download
M build/android/pylib/uiautomator/test_options.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 1 chunk +9 lines, -10 lines 0 comments Download
M build/android/test_runner.py View 1 4 chunks +6 lines, -0 lines 0 comments Download
M build/android/update_verification.py View 1 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbudorick
Created Revert of [Android] Reland cleanup of old_interface in build/android/pylib.
5 years, 8 months ago (2015-04-02 22:03:11 UTC) #1
jbudorick
Committed patchset #2 (id:270001) manually as bd6b7ec8c71da55fc79039374af97f77e5b2051b (presubmit successful).
5 years, 8 months ago (2015-04-02 22:55:36 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:29:34 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd6b7ec8c71da55fc79039374af97f77e5b2051b
Cr-Commit-Position: refs/heads/master@{#323573}

Powered by Google App Engine
This is Rietveld 408576698