Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1059443002: Revert of tidy up chromeos_setup.sh (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
Reviewers:
borenet, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of tidy up chromeos_setup.sh (patchset #1 id:1 of https://codereview.chromium.org/1051253002/) Reason for revert: arm_thumb not defined Original issue's description: > tidy up chromeos_setup.sh > > - remove unused alex > - streamline Link's config > - remove misleading Daisy config: > 1) armv7=1 does nothing. We meant to type arm_version=7 here. > 2) arm_neon=1 does nothing unless arm_version == 7. > 3) arm_thumb=0 is the default when arm_version <= 7. > 4) skia_arch_width=32 is the default when skia_arch_type=arm. > > I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and > arm_thumb=1, which I'm going to separately make the default for > arm_version=7), but there are known color-order bugs with our > NEON procs that would make Daisy start pushing bad images to > Gold. Going to take baby steps here... > > BUG=skia:1843 > > Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a TBR=borenet@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1843 Committed: https://skia.googlesource.com/skia/+/192945e92ef7ef97a307db636f242d58c98fff4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M platform_tools/chromeos/bin/chromeos_setup.sh View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of tidy up chromeos_setup.sh
5 years, 8 months ago (2015-04-02 16:01:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059443002/1
5 years, 8 months ago (2015-04-02 16:02:05 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 16:02:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/192945e92ef7ef97a307db636f242d58c98fff4e

Powered by Google App Engine
This is Rietveld 408576698