Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 105943007: Fix off-by-one error in AstTyper. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, rossberg
Visibility:
Public.

Description

Fix off-by-one error in AstTyper. This causes the first parameter to be confused with the first stack local when we collect type information. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18296

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/typing.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-param-local-type.js View 1 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years ago (2013-12-11 11:30:24 UTC) #1
Jakob Kummerow
LGTM!
7 years ago (2013-12-11 11:32:05 UTC) #2
Jakob Kummerow
LGTM!
7 years ago (2013-12-11 11:32:08 UTC) #3
Yang
7 years ago (2013-12-11 11:34:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18296.

Powered by Google App Engine
This is Rietveld 408576698